Re: [Simulavr-devel] Trouble building simulavrxx on Darwin

[Klaus Rudolph]

Hi Bill,


if a system did not define the constants we should not use them.
I prefer to #ifdef the line where the additional constants are used.
I cant believe that a system take acount on bits which are not defined.
And defining bits as workaround is not the solution here. Simply leave
them in the call if the system did not have them.
For that we could simply : ifdef POLLRDNORM ....
No aditional OS testing needed.


What do you think?


Bye
   Klaus

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> In that man page for poll I see the following text:
> 
> ~       When compiling XPG4.2 source one also has
> ~       #ifdef _XOPEN_SOURCE
> ~           #define POLLRDNORM  0x0040    /* Normal data may be read */
> ~           #define POLLRDBAND  0x0080    /* Priority data may be read */
> ~           #define POLLWRNORM  0x0100    /* Writing now will not block */
> ~           #define POLLWRBAND  0x0200    /* Priority data may be
> written */
> ~       #endif
> 
> My guess is that David doesn't have this. Klaus, would it be a bad
> idea for you to condition your use of POLLRDNORM on _XOPEN_SOURCE? I
> don't know the correct solution here....if you need that feature, then
> we need to find a solution. I also suspect that it is better for us to
> define our own #define for the use of this value, and let configure
> determine how whether or not to use it. (for all I know, other systems
> also provide/use this value)
> 
> 
> 
> Klaus Rudolph wrote:
> 
> | Hi David,
> |
> | the problem is related to OS X. 'POLLRDNORM' is defined somewhere
> | in the system header files  <asm/poll.h> in linux and it looks that
> | for OS X this is not correct. My problem is that I have no access
> | to any OS X machine. I google a bit and found that in OS X the
> | constants should be defined in poll.h
> |
> | Could you please try: #include <poll.h> in front of the file
> | mysocket.cpp. If this will not work, could you please grep through
> | your system header files for the lost constants and add the missing
> | header to mysocket.cpp and try to compile again, maybe we will run
> | in some more "compatibility" problems.
> |
> | I hope we will be able to make the simulavrxx running on OS X. If
> | so, we (Bill :-)) will change the configure tests for os x and we
> | could put that on the CVS.
> |
> | If you are not the familar with searching for such things you maybe
> | could give me or Bill access to your machine? If so please send me
> | a PM.
> |
> | Thank you for your help!
> |
> | Klaus
> |
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFBbzgnuZBxYuVmoeoRAtpRAJ4//gZhIoj4ohXcI++EUJeaE6CdXACggkgx
> 1EaH39bzXLAyyexd+E8Rqgk=
> =HAMl
> -----END PGP SIGNATURE-----
> 
> 
> 
> _______________________________________________
> Simulavr-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/simulavr-devel
> 

-- 
+++ GMX DSL Premiumtarife 3 Monate gratis* + WLAN-Router 0,- EUR* +++
Clevere DSL-Nutzer wechseln jetzt zu GMX: http://www.gmx.net/de/go/dsl