Re: [Protux-devel] Too much things to understand, but few to antecipate :

[Remon Sijrier]

> wow - so much things to understand from the implementation you send. I am

I think that it's most easy to read through the code. 
Have a look  at the declarations at Song, and the now completely new 
Jmb::broadcast_event()
The latter has some documentation in the code so it should be not so hard to 
understand from it how it works ;-)


> still reading it, many times, until it become clear...

See the above :-)


> but something here is critical, so I decide to antecipate it :
> > 011 < S >   (PARAMETER TYPE=INT "100")      "USE SONG"
>
> "USE SONG" ???
>
> This breaks the idea of "DO NOT GIVE ANY MEANING TO AN ACTION IN JMB.MAP "

Hehehehe, didn't you see it before? But as I said, text between quotes are not 
parsed, I used it as a memory helper. It can be removed, but I find it really 
very helpfull sometimes.

> 011 <S>  maps only a phisical action on the keyboard to an ID. It is the
> APPLICATION that decides, thru contextes, and all that stuff, what to do,
> and it what contextes with action 011. So this is completely wrong.

I suppose you refer to the "DO NOT GIVE ANY MEANING TO AN ACTION IN JMB.MAP"?
I completely agree.
But then this was wrong, wasn't it:

214 < S >   
011 < S > 

If multiple slots have to be connected to one mapped physical action, then the 
story becomes slightly more complicated :-(


> Now the parameter thing.
>
> it can be discarded, since the parameter was initially used to solve
> ambiguity conflicts. Now we are working on contextes, so parameter is
> useless..
>
> Hope that this helps..

I'm sorry, no :-(
For example, select has many functions. Different actions call this same slot: 
where this happens:

JmbSlot Song::select(JmbMessage* m)
{
        switch (m->parameter)
                case SELECT_ALL:
                case SELECT_NONE:
                etc.
}

Do we need to make a specific slot for each select action? There are more 
examples were Protux relies on this parameter thing, it is still really a 
handy thing to use for example one slot for actions which differ slightly 
only. 

> Now , I will read the previous emails more 163 times so I can undertand
> them hehehe..

Don't do it ;-)
I'm definitely not a teacher, so reading through the code should explain 
more...

Happy reading!

Remon


>
> > This is more or less urgent as Protux allready relies on this variable,
> > so to make Protux working again this has to be fixed as well.
> >
> > At this moment there can only be one jmb action associated with an action
> > id. So this is not valid:
> >
> > 214 < S >                   "SELECT"
> > 011 < S >                   "USE SONG"
> >
> > But this (could be) valid:
> >
> > 214 < S >                                                                   
> > "SELECT"
> > 011 < S >   (USE_COLLECTED_NUMBER)  "USE SONG"
> >
> > The text between quotes aren't parsed!
> >
> > Remon
> >
> >
> > _______________________________________________
> > Protux-devel mailing list
> > address@hidden
> > http://mail.nongnu.org/mailman/listinfo/protux-devel