[Protux-devel] Finish hold action should also broadcast action, JMB bug

[Remon Sijrier]

Hello Luciano,

Maybe you allready discovered this one, but if you didn't:

- Finish hold action should also broadcast action 

For example Dragging and Zooming rely on the release actions of its keys


I think I found also a bug in MustuxJogMouseBoard. 

int Jmb::identify_first_fact()
{
bladiebla etc...

and ends in the following condition:

PMESG3("No single fact candidate action found. Keep going, since a 2nd fact 
might come soon");
PEXIT3;
return -1;
}

But consider the situation where no second fact comes. Then no timer will be 
set to clear the output (stack) after some time.
This is exactly what happens when you use the short key "ALT - TAB" to lower a 
MustuxInterface !!

So it seems obvious to add  "give_a_chance_for_second_fact()" at the end of 
the method int Jmb::identify_first_fact()

The other problem with the "ALT - TAB" sequence is when we use it to raise a 
MustuxInterface. Then the first fact JMB will receive is a "RELEASE" action, 
which is put on stackIndex 0! JMB cannot handle that, so we need to check for 
this condition:

int Jmb::catch_release( QT_EVENT * e)
        {
        PENTER3;
        int k = uppercase(e->KEYBOARD_CODE());
        //Here we check if stackIndex != 0
        if (!is_fake(k) && stackIndex!=0)       //WAS ( !is_fake(k) )
                {
                push_event(JMB_EVENT_RELEASE, k);
                release_checker();
                }
        PEXIT3;
        return 1;
        }

Can you review this? I didn't commit it yet because you're bussy with this 
class as well, and you've more knowledge on how this class works....

Thanks,

Remon