Re: [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

[Juan Quintela]

Markus Armbruster <armbru@redhat.com> wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> We've been trying to reduce their remaining use.
>
> Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat
> imprecise error message
>
>     (qemu) x_colo_lost_heartbeat
>     Error: The feature 'colo' is not enabled
>
> to
>
>     Error: VM is not in COLO mode
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Althought in this case which error message is better is not so clear.
Colo mode is compiled in, but it is not being "enabled".

Later, Juan.