qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/12] dump: Improve error message when target doesn't suppor


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 02/12] dump: Improve error message when target doesn't support memory dump
Date: Tue, 7 Feb 2023 09:32:02 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

On 7/2/23 08:51, Markus Armbruster wrote:
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.

Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague
error message

     (qemu) dump-guest-memory mumble
     Error: this feature or command is not currently supported

to

     Error: guest memory dumping is not supported on this target

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  dump/dump.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dump/dump.c b/dump/dump.c
index 279b07f09b..80620da40d 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -1854,7 +1854,8 @@ static void dump_init(DumpState *s, int fd, bool 
has_format,
       */
      ret = cpu_get_dump_info(&s->dump_info, &s->guest_phys_blocks);
      if (ret < 0) {
-        error_setg(errp, QERR_UNSUPPORTED);
+        error_setg(errp,
+                   "guest memory dumping is not supported on this target");

"Dumping guest memory is not supported on this target"?

          goto cleanup;
      }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]