Re: [PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages

[Juan Quintela]

Markus Armbruster <armbru@redhat.com> wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> We've been trying to reduce their remaining use.
>
> The stubbed out Rocker monitor commands are the last remaining users
> of QERR_FEATURE_DISABLED.  They fail like this:
>
>     (qemu) info rocker mumble
>     Error: The feature 'rocker' is not enabled
>
> The real rocker commands fail like this when the named object doesn't
> exist:
>
>     Error: rocker mumble not found
>
> If that's good enough when Rocker is enabled, then it's good enough
> when it's disabled, so replace QERR_FEATURE_DISABLED with that, and
> drop the macro.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>