[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error mes
From: |
Markus Armbruster |
Subject: |
[PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message |
Date: |
Tue, 7 Feb 2023 08:51:14 +0100 |
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.
Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat
imprecise error message
(qemu) x_colo_lost_heartbeat
Error: The feature 'colo' is not enabled
to
Error: VM is not in COLO mode
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
migration/colo-failover.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/colo-failover.c b/migration/colo-failover.c
index 42453481c4..6cb6f90357 100644
--- a/migration/colo-failover.c
+++ b/migration/colo-failover.c
@@ -17,7 +17,6 @@
#include "migration.h"
#include "qapi/error.h"
#include "qapi/qapi-commands-migration.h"
-#include "qapi/qmp/qerror.h"
#include "qemu/error-report.h"
#include "trace.h"
@@ -78,7 +77,7 @@ FailoverStatus failover_get_state(void)
void qmp_x_colo_lost_heartbeat(Error **errp)
{
if (get_colo_mode() == COLO_MODE_NONE) {
- error_setg(errp, QERR_FEATURE_DISABLED, "colo");
+ error_setg(errp, "VM is not in COLO mode");
return;
}
--
2.39.0
- [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs, (continued)
- [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs, Markus Armbruster, 2023/02/07
- [PATCH 02/12] dump: Improve error message when target doesn't support memory dump, Markus Armbruster, 2023/02/07
- [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub, Markus Armbruster, 2023/02/07
- [PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages, Markus Armbruster, 2023/02/07
- [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message,
Markus Armbruster <=
- [PATCH 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/07
- [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/07
- [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub, Markus Armbruster, 2023/02/07