|
From: | Juan Quintela |
Subject: | Re: [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub |
Date: | Tue, 07 Feb 2023 09:51:25 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > We've been trying to reduce their remaining use. > > acpi_table_add() is only ever called on behalf of CLI option > -acpitable. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386, > it is reachable only for these targets. Since they provide a real > acpi_table_add(), the stub is unreachable. > > There's no point in unreachable code keeping QERR_UNSUPPORTED alive. > Dumb it down to g_assert_not_reached(). > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |