Re: [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub

[Juan Quintela]

Markus Armbruster <armbru@redhat.com> wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> We've been trying to reduce their remaining use.
>
> smbios_entry_add() is only ever called on behalf of CLI option
> -smbios.  Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 |
> QEMU_ARCH_ARM, it is reachable only for these targets.  Since they
> provide a real smbios_entry_add(), the stub is unreachable.
>
> There's no point in unreachable code keeping QERR_UNSUPPORTED alive.
> Dumb it down to g_assert_not_reached().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>