[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub
From: |
Markus Armbruster |
Subject: |
[PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub |
Date: |
Tue, 7 Feb 2023 08:51:08 +0100 |
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.
smbios_entry_add() is only ever called on behalf of CLI option
-smbios. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 |
QEMU_ARCH_ARM, it is reachable only for these targets. Since they
provide a real smbios_entry_add(), the stub is unreachable.
There's no point in unreachable code keeping QERR_UNSUPPORTED alive.
Dumb it down to g_assert_not_reached().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/smbios/smbios-stub.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/smbios/smbios-stub.c b/hw/smbios/smbios-stub.c
index 64e5ba93ec..e8808adfda 100644
--- a/hw/smbios/smbios-stub.c
+++ b/hw/smbios/smbios-stub.c
@@ -21,11 +21,9 @@
*/
#include "qemu/osdep.h"
-#include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
#include "hw/firmware/smbios.h"
void smbios_entry_add(QemuOpts *opts, Error **errp)
{
- error_setg(errp, QERR_UNSUPPORTED);
+ g_assert_not_reached();
}
--
2.39.0
- [PATCH 00/12] error: Reduce qerror.h usage a bit more, Markus Armbruster, 2023/02/07
- [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs, Markus Armbruster, 2023/02/07
- [PATCH 02/12] dump: Improve error message when target doesn't support memory dump, Markus Armbruster, 2023/02/07
- [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub,
Markus Armbruster <=
- [PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages, Markus Armbruster, 2023/02/07
- [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message, Markus Armbruster, 2023/02/07
- [PATCH 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/07
- [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/07