Re: [Gnu-arch-users] Re: Re: Having two precommit hooks

[Mikhael Goikhman]

On 11 Oct 2004 09:24:06 -0700, Thomas Lord wrote:
> 
>     > From: Anand Kumria <address@hidden>
> 
>     > Basically I think you need four hooks for commit:
>     >         - pre-commit-changeset (tree modifications allowed, reformat 
> code) 
>     >         - post-commit-changeset (no modifications allowed, ?) 
>     >         - pre-commit (no modifications allowed, run test suites) 
>     >         - post-commit (send notifications)
> 
>     > In some sense you could combine post-commit-changeset and pre-commit
>     > together; my thought is that post-commit-changeset could be used to 
> clean
>     > up after pre-commit-changeset.  In most cases it would not be necessary
>     > but you never know.
> 
> I think they should be combined (the existing pre-commit hook is
> sufficient).

So, returning to the original message that started this subject,
do you think the following hook names are intuitive enough:

        * prepare-commit
        * confirm-commit
        * post-commit

I would avoid precommit, pre-precommit and commit names as ambiguous.

Regards,
Mikhael.