gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] Re: Having two precommit hooks


From: Thomas Lord
Subject: Re: [Gnu-arch-users] Re: Having two precommit hooks
Date: Mon, 11 Oct 2004 09:04:04 -0700 (PDT)


    > From: Matthieu Moy <address@hidden>

    > >         #!/bin/sh

    > >         tla tree-lint
    > >         run-hook
    > >         tla commit

    > This will work when you call it, off course, but this seems to me to
    > be a dangerous solution if the correctness of your archive really
    > depends on "run-hook":

    > 1) It is easy to forget about the wrapper script, and run "tla commit"
    >    by mistake.

I don't find that argument persuasive but it's probably not important
to argue against because:


    > 2) front-ends to xtla won't be aware of the the wrapper script, and
    >    will run "tla commit" anyway. 
    [...]
    > By the way, is there a particular reason why there's a post-commit
    > hook ?

I do find those arguments persuasive.

-t




reply via email to

[Prev in Thread] Current Thread [Next in Thread]