simulavr-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Simulavr-devel] Intel hex format support


From: Theodore A. Roth
Subject: Re: [Simulavr-devel] Intel hex format support
Date: Tue, 1 Apr 2003 09:01:13 -0800 (PST)


On Tue, 1 Apr 2003, Jussi Pitkanen wrote:

:) Hello!
:)
:) Wow, simulavr is a cool project!

Thanks.

:) Patch for the intel hex format support is attached. Is this ok?

Looks good. Before I test it though, can you fix a few things
re-submit?

Please use avr_new() and avr_free() instead of calling malloc() and
free() directly.

You have used some magic numbers when allocating record buffers.

Also, I'm thinking about using the bfd library. This would give
support for many format (most importantly elf) without re-inventing
the wheel. Bfd supported is currently being added to avarice and once
we get that done, I should have a feel for what needs to be done in
simulavr.

In the mean time, I'll commit your patch after I test it.

Ted Roth




reply via email to

[Prev in Thread] Current Thread [Next in Thread]