Re: [Simulavr-devel] Intel hex format support

[Jussi Pitkanen]

> From: "Theodore A. Roth" <address@hidden>
> To: Jussi Pitkanen <address@hidden>
> CC: address@hidden
> Subject: Re: [Simulavr-devel] Intel hex format support
> Date: Tue, 1 Apr 2003 09:01:13 -0800 (PST)

> :) Patch for the intel hex format support is attached. Is this ok?
>
> Looks good. Before I test it though, can you fix a few things
> re-submit?
>
> Please use avr_new() and avr_free() instead of calling malloc() and
> free() directly.

ok.

> You have used some magic numbers when allocating record buffers.

Now this 'magic number' is defined (with comments) in utils.h.

> Also, I'm thinking about using the bfd library. This would give
> support for many format (most importantly elf) without re-inventing  the 
> wheel. Bfd supported is currently being added to avarice and once
> we get that done, I should have a feel for what needs to be done in
> simulavr.

Sounds good. I think it's the right way. Anyway, patch with the fixes is 
attached.

> In the mean time, I'll commit your patch after I test it.
>
> Ted Roth

--
Jussi Pitkanen


_________________________________________________________________
MSN 8 with e-mail virus protection service: 2 months FREE* 
http://join.msn.com/?page=features/virus

ihex2.diff
Description: Binary data