[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_ph
From: |
Alex Bennée |
Subject: |
Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr() |
Date: |
Sun, 23 Apr 2023 20:35:31 +0100 |
User-agent: |
mu4e 1.11.2; emacs 29.0.90 |
Richard Henderson <richard.henderson@linaro.org> writes:
> On 4/23/23 18:29, Philippe Mathieu-Daudé wrote:
>> On 23/4/23 11:14, Richard Henderson wrote:
>>> On 4/20/23 22:28, Anton Johansson wrote:
>>>> -void tb_invalidate_phys_addr(target_ulong addr)
>>>> +void tb_invalidate_phys_addr(vaddr addr)
>>>
>>> Hmm. This isn't a virtual address, so 'vaddr' isn't right.
>>> I'm sure we have something more appropriate.
>> tb_page_addr_t?
>
> No, it isn't a ram_addr_t either (see exec-all.h).
> Perhaps just uint64_t.
Surely hwaddr?
>
>
> r~
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- [PATCH 2/8] accel: Replace target_ulong with vaddr in probe_*(), (continued)
- [PATCH 2/8] accel: Replace target_ulong with vaddr in probe_*(), Anton Johansson, 2023/04/20
- [PATCH 5/8] accel/tcg: Replace target_ulong with vaddr in translator_*(), Anton Johansson, 2023/04/20
- [PATCH 8/8] tcg: Replace target_ulong with vaddr in tcg_gen_code(), Anton Johansson, 2023/04/20
- [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Anton Johansson, 2023/04/20
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Richard Henderson, 2023/04/23
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Philippe Mathieu-Daudé, 2023/04/23
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Richard Henderson, 2023/04/23
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(),
Alex Bennée <=
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Richard Henderson, 2023/04/23
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Anton Johansson, 2023/04/24
- Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr(), Philippe Mathieu-Daudé, 2023/04/24
[PATCH 4/8] accel/tcg: Replace target_ulong with vaddr in helper_unaligned_*(), Anton Johansson, 2023/04/20
[PATCH 6/8] accel/tcg: Replace target_ulong with vaddr in page_*(), Anton Johansson, 2023/04/20