Re: [PATCH 6/8] accel/tcg: Replace target_ulong with vaddr in page_*()

[Richard Henderson]

On 4/24/23 13:51, Anton Johansson wrote:
> On 4/23/23 11:13, Richard Henderson wrote:
> > On 4/20/23 22:28, Anton Johansson wrote:
> > > -static PageFlagsNode *pageflags_find(target_ulong start, target_long last)
> > > +static PageFlagsNode *pageflags_find(vaddr start, target_long last)
> >
> > Both arguments are target addresses.
>
> See comment in cover letter. In short, I'm unsure why the signedness matters
> here as even changing last from target_long to target_ulong breaks tests.

Really?  Odd.  It's clearly a typo for last to be signed.
I'll have a look.


r~