qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 34/54] tcg: Widen helper_*_st[bw]_mmu val arguments


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 34/54] tcg: Widen helper_*_st[bw]_mmu val arguments
Date: Sun, 23 Apr 2023 20:57:21 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 11/4/23 03:04, Richard Henderson wrote:
While the old type was correct in the ideal sense,
some ABIs require the argument to be zero-extended.
Using uint32_t for all such values is a decent compromise.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  include/tcg/tcg-ldst.h | 10 +++++++---
  accel/tcg/cputlb.c     |  6 +++---
  2 files changed, 10 insertions(+), 6 deletions(-)


-void helper_ret_stb_mmu(CPUArchState *env, target_ulong addr, uint8_t val,
+/*
+ * Value extended to at least uint32_t, so that some abis do not require

s/abis/ABIs/

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

+ * zero-extension from uint8_t or uint16_t.
+ */



reply via email to

[Prev in Thread] Current Thread [Next in Thread]