Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr()

[Philippe Mathieu-Daudé]

On 24/4/23 14:52, Anton Johansson wrote:
> On 4/23/23 21:42, Richard Henderson wrote:
> > On 4/23/23 20:35, Alex Bennée wrote:
> > > Richard Henderson <richard.henderson@linaro.org> writes:
> > >
> > > > On 4/23/23 18:29, Philippe Mathieu-Daudé wrote:
> > > > > On 23/4/23 11:14, Richard Henderson wrote:
> > > > > > On 4/20/23 22:28, Anton Johansson wrote:
> > > > > > > -void tb_invalidate_phys_addr(target_ulong addr)
> > > > > > > +void tb_invalidate_phys_addr(vaddr addr)
> > > > > >
> > > > > > Hmm.  This isn't a virtual address, so 'vaddr' isn't right.
> > > > > > I'm sure we have something more appropriate.
> > > > > tb_page_addr_t?
> > > >
> > > > No, it isn't a ram_addr_t either (see exec-all.h).
> > > > Perhaps just uint64_t.
> > >
> > > Surely hwaddr?

But hwaddr is only defined on system emulation...

> > Duh.  Thanks,
>
> Thanks guys, and hwaddr it shall be!