qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_ph


From: Anton Johansson
Subject: Re: [PATCH 7/8] cpu: Replace target_ulong with vaddr in tb_invalidate_phys_addr()
Date: Mon, 24 Apr 2023 14:52:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0


On 4/23/23 21:42, Richard Henderson wrote:
On 4/23/23 20:35, Alex Bennée wrote:

Richard Henderson <richard.henderson@linaro.org> writes:

On 4/23/23 18:29, Philippe Mathieu-Daudé wrote:
On 23/4/23 11:14, Richard Henderson wrote:
On 4/20/23 22:28, Anton Johansson wrote:
-void tb_invalidate_phys_addr(target_ulong addr)
+void tb_invalidate_phys_addr(vaddr addr)

Hmm.  This isn't a virtual address, so 'vaddr' isn't right.
I'm sure we have something more appropriate.
tb_page_addr_t?

No, it isn't a ram_addr_t either (see exec-all.h).
Perhaps just uint64_t.

Surely hwaddr?

Duh.  Thanks,

Thanks guys, and hwaddr it shall be!

--
Anton Johansson,
rev.ng Labs Srl.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]