qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/8] accel/tcg: Replace target_ulong with vaddr in page_*()


From: Anton Johansson
Subject: Re: [PATCH 6/8] accel/tcg: Replace target_ulong with vaddr in page_*()
Date: Mon, 24 Apr 2023 14:51:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0


On 4/23/23 11:13, Richard Henderson wrote:
On 4/20/23 22:28, Anton Johansson wrote:
-static PageFlagsNode *pageflags_find(target_ulong start, target_long last)
+static PageFlagsNode *pageflags_find(vaddr start, target_long last)

Both arguments are target addresses.

See comment in cover letter. In short, I'm unsure why the signedness matters
here as even changing last from target_long to target_ulong breaks tests.

--
Anton Johansson,
rev.ng Labs Srl.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]