gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] Re: Having two precommit hooks


From: Thomas Lord
Subject: Re: [Gnu-arch-users] Re: Having two precommit hooks
Date: Sun, 10 Oct 2004 15:46:00 -0700 (PDT)

    > From: Anand Kumria <address@hidden>
    > >     > Like others, I thought "precommit" suggests the tree may be 
modified.
    > >     > If we are going to have two precommit hooks, then I suggest to use
    > >     > intuitive names this time, i.e. prepare-commit and confirm-commit 
hooks.

    > > A "hook" is the opportunity to invoke a user-specified computation at
    > > a point during another computation when, otherwise, such invocation
    > > would be impossible.

    > > A pre-commit hook that allowed tree modifications would have to be
    > > run, in effect, before the commit did anything else at all. 

    > No, I would expect such a hook to run after a 'tla tree-lint'; no point
    > doing any reformatting work if tla will bitch and moan later on.

I can't imagine not wanting to re-run tree-lint after a tree-modifying
hook ran.  What's wrong with (in essense):


        #!/bin/sh

        tla tree-lint
        run-hook
        tla commit

?


-t





reply via email to

[Prev in Thread] Current Thread [Next in Thread]