Re: Adds incipit section to NR (issue 108270043 by address@hidden)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>; 
<address@hidden>; <address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Tuesday, August 19, 2014 6:11 PM
Subject: Re: Adds incipit section to NR (issue 108270043 by 
address@hidden)


> https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly
> File ly/property-init.ly (right):
>
> https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly#newcode293
> ly/property-init.ly:293: \once \override
> Staff.InstrumentName.self-alignment-X = #RIGHT
> I don't think we should prescribe Staff.InstrumentName.self-alignment-X
> here.  That is a user preference.  While it would be nice to glean that
> information from the outer Staff.InstrumentName.self-alignment-X, that's
> likely tricky to do while at the same time overriding the
> Staff.InstrumentName settings.
>
> So I'd rather suggest the syntax
> \incipit \with { \override InstrumentName.self-alignment-X = #RIGHT }
> {...}

Don't agree at all.  I'd accept it if you proposed an alternative that left 
aligned the instrument name as a possible option, but as it is, I believe 
right alignment is the correct option here.  It should require an override 
to change that.  Don't accept this change should delay pushing this patch.

> if you want such an override.  That could be achieved by putting an
> optional incipit-mods argument of type (ly:context-mod?
> (ly:make-context-mod)) before the incipit-music argument and then using
> \new MensuralStaff \with { instrumentName = #instrument-name \with
> #incipit-mods }
> (not sure about the last \with) instead of just \new MensuralStaff.
>
> https://codereview.appspot.com/108270043/diff/40001/ly/property-init.ly#newcode303
> ly/property-init.ly:303: ragged-last = ##f
> wouldn't we also want system-count = 1 here?
>
> https://codereview.appspot.com/108270043/

Possibly. I'd be happy to add that prior to push.

--
Phil Holmes