Re: [PATCH v2 07/21] include/exec/memattrs: Add two bits of space to MemTxAttrs

[Philippe Mathieu-Daudé]

On 21/2/23 11:50, Richard Henderson wrote:
> On 2/21/23 00:42, Philippe Mathieu-Daudé wrote:
> > On 21/2/23 11:01, Richard Henderson wrote:
> > > On 2/20/23 21:56, Philippe Mathieu-Daudé wrote:
> > > > 'secure' & 'user' seem mutually exclusive. If we get short in bits,
> > > > they could be shared.
> > >
> > > They are not.  ARM has Secure EL0, or secure user mode.
> >
> > Oh, I misunderstood this field with user-emulation then (I tried
> > commenting it and my TCG/HVF build succeeded).
>
> target/arm/ptw.c:2853:    result->f.attrs.user = regime_is_user(env, 
> mmu_idx);
>
> So... it shouldn't have built?

Eh correct... I guess I wasn't sitting in a directory with ARM target
selected when I tried that 🤦

../../hw/misc/armv7m_ras.c:19:15: error: no member named 'user' in 
'struct MemTxAttrs'
    if (attrs.user) {
        ~~~~~ ^