Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISAB

From:	Konstantin Kostiuk
Subject:	Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED
Date:	Tue, 7 Feb 2023 18:26:30 +0200

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Tue, Feb 7, 2023 at 10:53 AM Juan Quintela <quintela@redhat.com> wrote:

Markus Armbruster <armbru@redhat.com> wrote:
> slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED.
> This macro never existed. The reference got added in commit
> e3d4d25206a "guest agent: add guest agent RPCs/commands" along with
> QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However,
> QERR_QGA_LOGGING_FAILED was never actually used, and was removed in
> commit d73f0beadb5 "qerror.h: Remove unused error classes".
>
> Drop the dangling reference.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 09/12] replay: Simplify setting replay blockers, (continued)
- [PATCH 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/07
  - Re: [PATCH 09/12] replay: Simplify setting replay blockers, Philippe Mathieu-Daudé, 2023/02/07
    - Re: [PATCH 09/12] replay: Simplify setting replay blockers, Markus Armbruster, 2023/02/07
- [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/07
  - Re: [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Philippe Mathieu-Daudé, 2023/02/07
    - Re: [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message, Markus Armbruster, 2023/02/07
- [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub, Markus Armbruster, 2023/02/07
  - Re: [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub, Juan Quintela, 2023/02/07
- [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED, Markus Armbruster, 2023/02/07
  - Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED, Juan Quintela, 2023/02/07
    - Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED, Konstantin Kostiuk <=
- [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h", Markus Armbruster, 2023/02/07
  - Re: [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h", Juan Quintela, 2023/02/07
    - Re: [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h", Konstantin Kostiuk, 2023/02/07
- [PATCH 03/12] dump: Assert cpu_get_note_size() can't fail, Markus Armbruster, 2023/02/07
  - Re: [PATCH 03/12] dump: Assert cpu_get_note_size() can't fail, Juan Quintela, 2023/02/07
- [PATCH 07/12] hw/acpi: Move QMP command to hw/core/, Markus Armbruster, 2023/02/07
  - Re: [PATCH 07/12] hw/acpi: Move QMP command to hw/core/, Juan Quintela, 2023/02/07
- Re: [PATCH 00/12] error: Reduce qerror.h usage a bit more, Philippe Mathieu-Daudé, 2023/02/07

Prev by Date: Re: [PATCH 2/3] intel-iommu: fail DEVIOTLB_UNMAP without dt mode
Next by Date: Re: [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h"
Previous by thread: Re: [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED
Next by thread: [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h"
Index(es):
- Date
- Thread