Re: [Monotone-devel] Thoughts about 'testresult'...

[Emile Snyder]

On Thu, 2005-04-21 at 08:10, Richard Levitte - VMS Whacker wrote:
> esnyder> Does update now never update you to a rev with a true
> esnyder> testcert *unless* you give it this selector?  That seems
> esnyder> counter-intuitive in the other direction.
> 
> Why?  Basically, whoever wants to go for revisions where I confirm
> that 'make check' works for me would simply do this:
> 
>       monotone update r:address@hidden
>
> Nothing stops you from getting that revision anyway if that happens to
> be the (single) head, AND it wouldn't get us into the surprising
> effect we had a few days ago.

I see, you would also like to either remove the
accept_testresult_change() hook call, or redefine the default to 'return
true' ?  Because if we don't, then once you have called 'monotone update
r:address@hidden' you are back in exactly the same old situation,
right?

The other thing that seems a little funny to me is that I'm used to
thinking of selectors as handy ways to try to pick a single revision; it
complains if it finds lots if I do 'monotone update a:richard' because
there's lots of such revisions, and 'monotone update REV' takes one.  

The usage you're talking about seems more natural to me as 'monotone
--testresult=true update' in analogy to the --branch flag; ie. restrict
the graph of interest to revs with the given branch/testresult cert.

Do we have other commands where we use selectors in the way you've
proposed for r: ?

Out of curiosity, is there an argument against having the general case
flag, --cert=certname:certvalue that behaves like --branch: restricting
the considered graph to revisions that have the given cert with the
given value?

> esnyder> r: makes me thing revision, is t: taken?
> 
> t is for tag.  Otherwise, I'd agree with you.

doh.  right.

thanks,
-emile

+----------------------------------------------------------------------
You possess a mind not merely twisted, but actually sprained. -- BSD
fortune file 
+----------------------------------------------------------------------