[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix Issue 2462. (issue 108280044 by address@hidden)
From: |
janek . lilypond |
Subject: |
Re: fix Issue 2462. (issue 108280044 by address@hidden) |
Date: |
Fri, 11 Jul 2014 06:40:39 +0000 |
Thanks for review! Pushed as
commit ab6842155a003ba7d9243507594e3e973ebbb3e4
Author: Janek Warchoł <address@hidden>
Date: Mon Jun 30 22:14:16 2014 +0200
Issue 2462 : don't change ideal spacing when adding a rod
When objects like lyrics are added to the PaperColumns, LilyPond
inserts
rods between these columns to ensure that the objects won't overlap.
However, the ideal distance should remain unchanged. For example,
in
\layout {
ragged-right = ##f
}
\relative f' { \repeat unfold 8 a4 }
\addlyrics { \repeat unfold 4 la \repeat unfold 4 straight }
notes in 2nd measure have long lyrics attached to them -
min_distance_
of the springs between these columns should be adjusted, but
distance_
(the ideal distance) should not: it should be the same as for notes
with short lyrics. When the line is stretched so much that the
minimum
distances are not involved, the springs between notes in both
measures
should behave (almost) identical.
Note that there are more such problems in the springs code, for
example
in merge_springs. The code should be rewritten, but that's not
trivial.
Since this one-liner fixes some instances of the problem without any
bad
side-effects, it makes sense to include it separately.
I have opened https://code.google.com/p/lilypond/issues/detail?id=4006
for the remainder of the spring code problems.
https://codereview.appspot.com/108280044/
Re: fix Issue 2462. (issue 108280044 by address@hidden), k-ohara5a5a, 2014/07/07
Re: fix Issue 2462. (issue 108280044 by address@hidden),
janek . lilypond <=