fix Issue 2462. (issue 108280044 by address@hidden)

[k-ohara5a5a]

This does make sense, but if you change the basic rules of a Spring
(allowing the natural length to be less than the minimum-distance
constraint, so it stays at the minimum length until the line is
considerably stretched) you should try to make the change consistently
everywhere ?


https://codereview.appspot.com/108280044/diff/1/lily/spring.cc
File lily/spring.cc (left):

https://codereview.appspot.com/108280044/diff/1/lily/spring.cc#oldcode192
lily/spring.cc:192: distance_ = max (distance_, min_distance_);
Only caller is Simple_spacer::add_rod() and it certainly seems simpler
if adding a min_distance constraint (adding a 'rod') leaves the ideal
spacing (the 'spring') unchanged.

https://codereview.appspot.com/108280044/diff/1/lily/spring.cc
File lily/spring.cc (right):

https://codereview.appspot.com/108280044/diff/1/lily/spring.cc#newcode87
lily/spring.cc:87: distance_ = max (min_distance_, distance_ * r);
maybe  *= r;

https://codereview.appspot.com/108280044/diff/1/lily/spring.cc#newcode120
lily/spring.cc:120: avg_distance = max (min_distance + 0.3,
avg_distance);
Logically, this would be removed as well, except that it also adds 0.3.
When you tried removing this line, you said there were unwanted
side-effects. What cases needed the extra 0.3 of space?  It would be
much better to include it in padding parameters, than to have this
deeply-hidden offset.

https://codereview.appspot.com/108280044/