|
| From: | dak |
| Subject: | Re: Set X-parent of TextScript to NoteColumn instead of PaperColumn (issue 106640043 by address@hidden) |
| Date: | Fri, 11 Jul 2014 11:10:10 +0000 |
https://codereview.appspot.com/106640043/diff/20001/lily/note-column.cc File lily/note-column.cc (right): https://codereview.appspot.com/106640043/diff/20001/lily/note-column.cc#newcode169 lily/note-column.cc:169: if (head) Why would this test become required when it wasn't before? Doesn't this imply that you are now calling this function prematurely? https://codereview.appspot.com/106640043/diff/20001/lily/text-engraver.cc File lily/text-engraver.cc (right): https://codereview.appspot.com/106640043/diff/20001/lily/text-engraver.cc#newcode34 lily/text-engraver.cc:34: struct Script_tuple Why? You never exploit the connection between grob and event, so why would you need to combine grobs and events in one array? https://codereview.appspot.com/106640043/
| [Prev in Thread] | Current Thread | [Next in Thread] |