Re: Adds bar line section to LM (Issue 3408) (issue 12724043)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, August 12, 2013 3:50 PM
Subject: Re: Adds bar line section to LM (Issue 3408) (issue 12724043)


> On 2013/08/12 13:48:32, email_philholmes.net wrote:
> > ----- Original Message -----
> > From: <mailto:address@hidden>
> > To: <mailto:address@hidden>
> > Cc: <address@hidden>;
> <mailto:address@hidden>
> > Sent: Sunday, August 11, 2013 3:33 PM
> > Subject: Re: Adds bar line section to LM (Issue 3408) (issue 12724043)
>
>
> > > Non-standard headings; otherwise LGTM.
> > >
> > >
> > >
>
> https://codereview.appspot.com/12724043/diff/1/Documentation/learning/common-notation.itely
> > > File Documentation/learning/common-notation.itely (right):
> > >
> > >
>
> https://codereview.appspot.com/12724043/diff/1/Documentation/learning/common-notation.itely#newcode67
> > > Documentation/learning/common-notation.itely:67: @subheading Bar
> lines
> > > @unnumberedsubsubsec
> > > plus @node and menu
> > > See
> > >
>
> http://www.lilypond.org/doc/v2.17/Documentation/contributor/sectioning-commands
> > >
> > >
>
> https://codereview.appspot.com/12724043/diff/1/Documentation/learning/common-notation.itely#newcode80
> > > Documentation/learning/common-notation.itely:80: @subheading Bar
> checks
> > > ditto
> > >
> > > https://codereview.appspot.com/12724043/
>
> > More than happy to make this change, but there's lots and lots of
> subheading
> > headings in that file - should they all be taken out?
>
> > --
> > Phil Holmes
>
>
> Well, it's quite a bit of work as they'll need menus and nodes
> adding.  Each subsubsec will be rather small, but I think it is
> well worth doing as these subsubsecs can then be referenced
> individually and they'll appear as headings in the ToC.  They
> can also be given a more direct reference from the indexes.
>
> https://codereview.appspot.com/12724043/


OK - I suggest I don't change my patch as you've suggested, because the way 
I did it was to copy the original, and so it currently follows the style for 
that section.  I'll raised an issue to change all instances of @subheading 
to @unnumberedsubsubsec in the LM and do that once this patch is pushed. 
That sound OK?

--
Phil Holmes