[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Eliminates the Hara_kiri_engraver. (issue 7061062)
From: |
dak |
Subject: |
Re: Eliminates the Hara_kiri_engraver. (issue 7061062) |
Date: |
Fri, 25 Jan 2013 09:29:28 +0000 |
On 2013/01/25 08:05:28, Keith wrote:
https://codereview.appspot.com/7061062/diff/9001/lily/axis-group-engraver.cc
File lily/axis-group-engraver.cc (right):
https://codereview.appspot.com/7061062/diff/9001/lily/axis-group-engraver.cc#newcode120
lily/axis-group-engraver.cc:120: // mess everything up...but at least
this
avoids a duplicate context
Please demonstrate a sneaky callback messing things up.
Since sneaky callbacks can mess a lot of things up, a comment like that
would likely be only warranted if "sneaky callback" can cause conditions
that lead to programming errors, and possibly even just crashes.
https://codereview.appspot.com/7061062/
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), (continued)
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/14
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/14
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), dak, 2013/01/14
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), dak, 2013/01/20
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), mtsolo, 2013/01/20
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/21
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/21
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/21
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/25
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062),
dak <=
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), dak, 2013/01/25
- Re: Eliminates the Hara_kiri_engraver. (issue 7061062), k-ohara5a5a, 2013/01/26