|
From: | Keith OHara |
Subject: | Re: Eliminates the Hara_kiri_engraver. (issue 7061062) |
Date: | Mon, 14 Jan 2013 11:30:21 -0800 |
User-agent: | Opera Mail/12.01 (Win32) |
On Mon, 14 Jan 2013 10:25:24 -0800, <address@hidden> wrote:
If you can access the value with staffline_ && to_boolean(staffline_ -> get_property("remove-empty")) at this point, that would seem to be simpler.It would also mean that we can just leave keepAliveInterfaces alone when switching between harakiri behavior and otherwise. Having to override a complex variable back and forth for a basic switch in behavior is error-prone.
Unfortunately, 'remove-empty is a property of the VerticalAxisGroup (the grouping-object that holds a line) so the same value of 'remove-empty gets copied to the broken lines. The separate VerticalAxisGroup objects for each broken line are not created by the engraver, but by the line-breaker, so changing the property with \set s in the input does not change it in the appropriate lines of output. keepAliveInterfaces can be changed in the music stream.
https://codereview.appspot.com/7061062/
[Prev in Thread] | Current Thread | [Next in Thread] |