FW: diagram low-bass-clarinet: diagramm - line before

[Carl Sorensen]

>I'm top-posting because of a forward.

Markus has proposed a patch to fix the names of bass-clarinet keys in
woodwind diagrams.

Markus,  when we review patches, we do it on -devel, so I've forwarded this
to -devel.

On Monday 17 January 2011 20:55:51 Markus Schnider wrote:
> Hallo
>
> I've tried to change the key names.
> (see attachments)
>
> I've also made other changes. This is not the best, but a little optimised
> ... (d -> low-d
> ees -> e [both side]
> e -> m-e [left-hand middle-e]

why not middle-e?

> e -> gis,
> f -> low-es,
> gis -> f)
>
> I've not tested the (text? . ("F" . 0)) construct.

Please do so.

>
> I'm not trying to create a convert-ly.

Before we can accept a patch that changes syntax (which this one does), we
need to have a convert-ly rule.  A NOT_SMART rule should be pretty easy to
write.

>
> Thanks for the other answers.
>
> Markus
>
> On Monday 17 January 2011 17:19:18 Carl Sorensen wrote:
> > On 1/16/11 5:53 AM, "Markus Schnider" <address@hidden> wrote:
> > > Hallo
> >
<snip>
> > > There is still missing some keys for the "low-bass" clarinet.
> > > There are also a low-d key for the right thumb like low-cis and low-c.
> > > This low-d is on some bass-clarinets also on the left side available.
> >
> > This should be filed as a bug report.  You've posted to the right place.
> > Perhaps our on-duty BugSquad member will respond.
> >
> > > Why are the keys for some fingering wrong?
> >
> > Perhaps because the author of the fingering charts had different names
> > for the keys.  And perhaps it's just because of a mistake.
> >
> > > (The output could be correct if you choose the names instead of the
> > > notes). This is in the low register for all clarinets:
> > > (rh . (f)) should be (rh . (low-dis)) -> only bass and low-bass
> > > clarinet (rh. (ees)) should be (rh . (low-e)) or (rh . (h))
> > > (rh. (gis)) should be (rh . (low-f)) or (rh . (c))
> > > (rh. (e)) should be (rh . (low-gis)) or (rh . (es))
> > > Or how could I change these errors?
> >
> > In looking briefly at the current code, it appears that all of the
> > clarinets share the same set of key names, but I'm not really familiar
> > with the code.
> >
> > The code that sets up the names of the diagram keys is found in
> > scm/display-woodwind-diagrams.scm.  The code defining the stencils is in
> > scm/define-woodwind-diagrams.scm.  Patches that improve the behavior
> > would be appreciated.  I'll provide any support I can as you try to fix
> > these things.
> >
> > > I don't know where I should change
> > > something (for the convert-ly)
> >
> > Fixing this with convert-ly would be very difficult, as it would only
> > apply to certain instruments.  But it may be possible.  Are you familiar
> > with Python or with regexps?
> >
> > HTH,
> >
> > Carl

display-woodwind-diagrams.scm.diff
Description: display-woodwind-diagrams.scm.diff

display-woodwind-diagrams.scm
Description: display-woodwind-diagrams.scm