lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Potential fix for issue 37


From: Mike Solomon
Subject: Re: Potential fix for issue 37
Date: Thu, 13 Jan 2011 13:07:05 -0500

Hey Jan,

Please check out http://codereview.appspot.com/3928041/ for the most recent version, which has a regtest.

Cheers,
MS

On Jan 13, 2011, at 12:49 PM, Jan Nieuwenhuizen wrote:

[cc: lilypond-devel]

This looks great, I don't see a regression test file; are you
adding that please?

Jan

Mike Solomon schreef op vr 07-01-2011 om 20:54 [-0500]:
Kinda meh, but it gets the job done!  I've included three patches,
including the original.
The second preserves the flat beams but gets rid of the crashing lily,
whereas the third implements some bendiness.


Cheers,
MS





On Jan 7, 2011, at 6:11 PM, Jan Warchoł wrote:

2011/1/7 <address@hidden>
       I'm not exactly sure what the desired output would be for
       issue 37, but my code assumes that if there are collision
       problems, flat beams look best.

       Lemme know what you think!


Judging by my very own personal taste i'd say that when notes are
not on the same staffline it would look better if the beams were
slanted; i'd also prefer slightly smaller vertical gap between upper
beams and noteheads (now it's something like 1 staff space, i'd go
for 0.5 staff space). And it would be great if beams covered
stafflines like in regular situations.
But this is my personal opinion and of course the new output is far
better than the old one, so keep up the good work!


cheers,
Janek
_______________________________________________
lilypond-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/lilypond-devel


_______________________________________________
lilypond-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/lilypond-devel




reply via email to

[Prev in Thread] Current Thread [Next in Thread]