[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices
From: |
Michael Brown |
Subject: |
Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices |
Date: |
Fri, 12 Feb 2016 13:27:30 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 10/02/16 00:56, Eric S. Raymond wrote:
Is there any reason the stash buffer feature sould not always be enabled.
It shouldn't cause any functional problems, but it does add another 516
bytes to gps_lexer_t (if that matters).
I think I'd prefer it not to be an exposed configuration knob, but only
set when a driver needs it (which is just yours, I think).
Trivial patch to do this inline below, if you want it.
Michael
diff --git a/SConstruct b/SConstruct
index 9584c31..019fb71 100644
--- a/SConstruct
+++ b/SConstruct
@@ -147,7 +147,6 @@ boolopts = (
("timing", False, "latency timing support"),
("control_socket", True, "control socket for hotplug notifications"),
("systemd", systemd, "systemd socket activation"),
- ("stash", True, "enable stash buffer"),
# Client-side options
("clientdebug", True, "client debugging support"),
("ncurses", True, "build with ncurses"),
diff --git a/gpsd.h-tail b/gpsd.h-tail
index c51cda9..fd834be 100644
--- a/gpsd.h-tail
+++ b/gpsd.h-tail
@@ -65,6 +65,9 @@
#ifdef NTPSHM_ENABLE
#define TIMEHINT_ENABLE
#endif
+#ifdef ISYNC_ENABLE
+#define STASH_ENABLE
+#endif
/* First, declarations for the packet layer... */
- [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 1/4] [oscillator] Add concept of a GPS-disciplined oscillator, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 3/4] [isync] Parse iSync $PTNTA oscillator status packets, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 2/4] [stash] Add support for stashed partial messages, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 4/4] [isync] Autodetect and configure Spectratime iSync device, Michael Brown, 2016/02/03
- Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices, Eric S. Raymond, 2016/02/09