[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices
From: |
Eric S. Raymond |
Subject: |
Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices |
Date: |
Tue, 9 Feb 2016 16:48:14 -0500 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Michael Brown <address@hidden>:
> On 29/01/16 18:19, Eric S. Raymond wrote:
> > Jon Schlueter <address@hidden>:
> >> one thing I'd like to see added would be some regression sample data
> >>
> >> see "scons check" for sections where it runs through test/daemon/*.log
> >
> > Seconded. Other the patch set looks pretty good. Well done writing actual
> > documentation for the feature!
>
> Thanks! I've updated the patch to:
>
> - include regression sample data for "scons check"
> - increase gpsfake initial delay time (to avoid breaking "scons check")
> - move the oscillator_t inside the union in gps_data_t
> - document the changes made to code outside of the iSync driver
>
> Please let me know if anything else needs fixing!
>
> Michael
These look like good work. I have merged them.
However, something went wrong with the way patch 4 was generated and I
had to do some of the merging by hand. Please verify that these changes
look right and operate correctly for you. Also, compare the isync-log
and isync-log.chk files to yours - I had to regenerate the .chk file
due to a botched patch.
Is there any reason the stash buffer feature sould not always be enabled.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>