Re: [gpsd-dev] [PATCH 2/3] Fixes dbus linking on non-Linux platforms.

[Fred Wright]

On Tue, 9 Feb 2016, Eric S. Raymond wrote:

> Fred Wright <address@hidden>:
> > Commit 6e1d6bd6f51b3a66de029792433dcbfc9fe4a048 added "LIBPATH='.'"
> > overrides to most build setups, though the purpose was unclear.  The
> > SConstruct script already sets up LIBPATH to include the current
> > directory, as well as the proper directory for the dbus library when
> > dbus support is included, so the effect of the overrides was to undo
> > the latter.  This typically doesn't hurt on Linux, where the dbus
> > library is installed in a "system" library area which is searched by
> > default, but on OSX and BSD platforms it results in link errors.
> > Removing the overrides fixes this.
> >
> > TESTED:
> > Tested builds and ran regression tests on all OSX versions from 10.5
> > through 10.11, as well as Ubuntu 14.04.1, FreeBSD 10.1, OpenBSD 5.6,
> > and NetBSD 6.1.5.
>
> I merged your other two patches.  This one will take a little thought.

I expect that the real issue is in trying to determine whether there's
some case that actually needs the LIBPATH='.' overrides (in which case
there'd need to be a different solution since those break a bunch of
things as noted), or whether it was just a case of "seemed like a good
idea at the time". :-) The commit description provides no enlightenment.

Meanwhile, others might try out this patch to add to the testing coverage.
I've rebased my macports branch on GitHub to the current state of the
master branch here, so a pull from there is a simple fast-forward.  One
can just do:

git fetch https://github.com/fhgwright/gpsd.git macports && git branch macports 
FETCH_HEAD

to get a local macports branch with this patch (without perturbing the
working directory).

Fred Wright