[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices
From: |
Eric S. Raymond |
Subject: |
Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices |
Date: |
Tue, 9 Feb 2016 19:56:28 -0500 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Michael Brown <address@hidden>:
> Sorry about that. "git send-email" did complain about a line longer than
> the SMTP-permitted maximum of 998 characters (in the regression test data);
> this may have been the source of the problem.
Yeah, that fits. The line git am said was corrupt was in the middle
of a test log.
> I have verified that the patches as merged are correct:
>
> # Rebase my branch onto immediately preceding commit:
> git checkout isync
> git checkout -b temp
> git rebase d019151
>
> # View differences against final commit as merged
> git diff -b ce10b16
>
> The only non-whitespace difference I see is your added comment in gpsfake.
And that's the exact difference I expected.
> >Is there any reason the stash buffer feature sould not always be enabled.
>
> It shouldn't cause any functional problems, but it does add another 516
> bytes to gps_lexer_t (if that matters).
I think I'd prefer it not to be an exposed configuration knob, but only
set when a driver needs it (which is just yours, I think).
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
- [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 1/4] [oscillator] Add concept of a GPS-disciplined oscillator, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 3/4] [isync] Parse iSync $PTNTA oscillator status packets, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 2/4] [stash] Add support for stashed partial messages, Michael Brown, 2016/02/03
- [gpsd-dev] [PATCH 4/4] [isync] Autodetect and configure Spectratime iSync device, Michael Brown, 2016/02/03
- Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices, Eric S. Raymond, 2016/02/09