[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Bug-gnubg] Proposed patches to the gnubg sources

From: macherius
Subject: RE: [Bug-gnubg] Proposed patches to the gnubg sources
Date: Mon, 7 Feb 2005 13:55:00 +0100

> I'm not that bothered to be fair.  Perhaps if the #if also 
> checked _MSC_VER - i.e. is the microsoft compiler being used 
> it would be ok.

OK, the magic #if is:
#if defined(WIN32) && (defined(__INTEL_COMPILER) || defined(_MSC_VER))

Rationale: Intel C exists for both Linux and Windows, thus checking for
WIN32 still is required. Furthermore it is not stand-alone but piggybacks
Visual Studio, i.e. shares all the include files. Please find attached the
patched patch.

It may even make sense to change the test to positively check for MINGW gcc,
as the official MS headers ARE broken and every compiler not bringing its
own headers will fall the trap.

And while on the subject of patching patches, the gtkpanels.c cosmetic patch
had an error, of course it needs to read "#else" and not "#elif". Please
change that before applying. Thanks.


Attachment: gnubg_v2.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]