[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] Proposed patches to the gnubg sources

From: Jon Kinsey
Subject: Re: [Bug-gnubg] Proposed patches to the gnubg sources
Date: Mon, 07 Feb 2005 10:34:29 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041206 Thunderbird/1.0 Mnenhy/0.7

macherius wrote:
jon_kinsey wrote:

* board3d/ drawboard.c font3d.cpp graph.c gtkcolour.c matrix.c misc3d.c

model.c shadow.c

- include windows.h before GL headers, otherwise definitions in the Open

GL headers are

missing and yieding compiler errors

A better(?) fix is to add #include <windows.h> to the gl.h microsoft

include file - it should > be in there and all the other gl.h files I've
come across are fine.

You are the maintainers here, but I don't like the idea to change third
party headers to compile just any open souce. Gnubg was harder to compile
than anything else I ported so far, and that included some weird stuff like
gcc for Sinix on MIPS. Checkout, compile and face dozens of unnecessary
warnings and errors. Is it really required to have such oddities, in
particular where the patches to gnubg are there, and come at no cost?

I'm not that bothered to be fair.  Perhaps if the #if also checked
_MSC_VER - i.e. is the microsoft compiler being used it would be ok.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]