Re: [RP] Spam & Bugs

[Dylan Evans]

--- Judd Storrs <address@hidden> wrote:
> I eventually decided that the Solaris hack wasn't
> needed on FreeBSD
> and I was going to post my workaround, but
> coincidentally everyone
> else started talking about the idea that
> 
>    #if !defined(HAVE_SETENV) || !defined(setenv)
> 
> should be
> 
>    #if !defined(HAVE_SETENV) && !defined(setenv) 
> 
> I wasn't sure what the final decision on the matter
> was, but CVS is
> still ||. On FreeBSD, ./configure does find setenv
> and HAVE_SETENV is
> set in config.h. I don't know why setenv is
> undefined when RP is
> building actions.c on FreeBSD: ratpoision.h includes
> stdlib.h
> already. ChangeLog suggests that:
> 
> 2002-04-25  Gergely Nagy  <address@hidden>
> 
>         * src/actions.c: include <strings.h>
>         include setenv implementation if HAVE_SETENV
> is not set,
>         OR setenv is not defined (removes a compiler
> warning on
>         AIX)
> 
> But at least on FreeBSD it forces the override of
> native setenv with
> the buggy actions.c version designed for Solaris. So
> maybe the correct
> solution is to just live with a compiler warning on
> AIX:
> 
>    #if !defined(HAVE_SETENV)
> 
> --judd

That looks like the right way to fix it.
Thanks.



> The FreeBSD ratpoison-1.1.1 port currently builds
> and runs without
> core dumping on at least 4.7-RELEASE and 4.7-CURRENT
> with the
> following patch:
> 
> *** src/actions.c.orig               Sun Nov  3 12:58:30
> 2002
> --- src/actions.c            Sat Jul  6 17:31:27 2002
> ***************
> *** 2078,2084 ****
>     return NULL;
>   }
>   
> ! #if !defined(HAVE_SETENV) || !defined(setenv)
>   /* For systems, such as Solaris, where setenv is
> not implemented
>    * in libc */
>   /* FIXME: overwrite has no effect in this
> implementation! */
> --- 2078,2084 ----
>     return NULL;
>   }
>   
> ! #if !defined(HAVE_SETENV) && !defined(setenv)
>   /* For systems, such as Solaris, where setenv is
> not implemented
>    * in libc */
>   /* FIXME: overwrite has no effect in this
> implementation! */
> 
> 



__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com