[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use aligned-on-x-parent instead of other callbacks for some grobs (i
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden) |
|
Date: |
Mon, 18 Aug 2014 04:57:08 +0000 |
Looks fine;
just a minor unrelated change in code-organization looks unwise.
https://codereview.appspot.com/127860043/diff/40001/lily/lily-guile.cc
File lily/lily-guile.cc (right):
https://codereview.appspot.com/127860043/diff/40001/lily/lily-guile.cc#newcode201
lily/lily-guile.cc:201: robust_scm2bool (SCM b, bool def)
I am not sure, but I think this is a bad idea.
to_boolean() is robust to undefined symbols, returning #f, and a lot of
define-grobs.scm depends on that convention.
If you add this variant, and people start writing C++ that treats
undefined symbols as #t, we might get confused.
https://codereview.appspot.com/127860043/
- Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), k-ohara5a5a, 2014/08/10
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden),
k-ohara5a5a <=
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), janek . lilypond, 2014/08/18
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), dak, 2014/08/20
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), janek . lilypond, 2014/08/27
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), dak, 2014/08/29
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), pkx166h, 2014/08/30
- Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden), dak, 2014/08/30