Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden)

[Janek Warchoł]

2014-08-30 0:21 GMT+02:00  <address@hidden>:
>
> https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc
> File lily/note-column.cc (right):
>
> https://codereview.appspot.com/127860043/diff/80001/lily/note-column.cc#newcode167
> lily/note-column.cc:167: Grob *main_head;
> This is a catastrophic error.  If get_stem (me) returns 0 and there are
> no grobs in note-heads, main_head is not initialized at all but gets a
> random value.  The rest of the code more likely than not then calls
> Grob::extent on this random value.

Ooops, i'm sorry for that.  I have limited internet access for the
weekend; i'll upload a fix for review when i'm back home (feel free to
make a fix yourself if you want).

> It would have been easy to notice this error: GCC puts out a quite
> accurate warning.
>
> Ignoring GCC's warnings is rarely a good idea.

I didn't yet manage to find this warning in make output.  It's really
hard to see valuable information there... :/

best,
Janek