[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 2507: Stop the entanglement of context properties and grob pro
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Issue 2507: Stop the entanglement of context properties and grob property internals (issue 126280043 by address@hidden) |
|
Date: |
Mon, 18 Aug 2014 05:51:21 +0000 |
Big change, looks good, just one question.
https://codereview.appspot.com/126280043/diff/40001/lily/context-property.cc
File lily/context-property.cc (right):
https://codereview.appspot.com/126280043/diff/40001/lily/context-property.cc#newcode152
lily/context-property.cc:152: Don't mess with MIDI.
I am confused by this comment. MIDI output does not create any grobs,
so I figured the code would return false after finding no definition of
symbol_, same as if I type \override Bogus.color =#red
What is the special case for MIDI ?
https://codereview.appspot.com/126280043/