lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use aligned-on-x-parent instead of other callbacks for some grobs (i


From: janek . lilypond
Subject: Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden)
Date: Wed, 27 Aug 2014 07:45:02 +0000

Thanks for reviewing!  I have pushed this as

commit 48678617b169957433c562612151f2a71be50b59
Author: Janek Warchoł <address@hidden>
Date:   Sun Aug 10 21:09:42 2014 +0200

    Use aligned-on-x-parent instead of other callbacks for some grobs

    Now that we have an easy way of specifying different alignments for
    grob and its parent (see 0c4f221e5d), we can use aligned-on-.-parent
    in places that we previously used .-aligned-on-self.  With this
change,
    the users have more control over the placement of grobs.

    Affected grobs:
    - InstrumentSwitch
    - Script
    - SostenutoPedal
    - SustainPedal
    - UnaCordaPedal

commit 2c279ba4a1602f72afa2940b51c5e50d8c5a4b60
Author: Janek Warchoł <address@hidden>
Date:   Sun Aug 17 16:14:11 2014 +0200

    Fix bugs with aligning on main part of the NoteColumn

    NoteColumns may contain either noteheads or rests, so the function
    was changed to handle the case when NoteColumn contains only rest.

    ly_scm2bool returns true when the argument is unset - that's not
    what we want: unset properties should evaluate to false.


https://codereview.appspot.com/127860043/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]