Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by address@hidden)

[Janek Warchoł]

2014-08-20 10:50 GMT+02:00  <address@hidden>:
>  Somewhat irritatingly, separately to to_boolean there _does_ exist a
> ly_scm2bool (which is equivalent to scm_is_true and thus defaults to #t
> (!) when given a non-boolean).

Yes, this is very unintuitive.

> It is used a few times in our code base.
>  Most of the uses should likely be replaced by to_boolean, some
> conceivably by scm_is_true.  And afterwards, all instances of to_boolean
> should be renamed to ly_scm2bool and the behavior of _that_ changed to
> be that of to_boolean.
>
>> So, my question is: can we do something to make this more intuitive?
>
> The most important answer to that question in this context is: not as
> part of *this* issue.  Please use to_boolean here.  I remember being
> tripped up by ly_scm2bool at some point of time in the past.  I'm
> definitely sympathetic to changing its behavior to that of to_boolean
> and getting rid of to_boolean altogether (after making sure that all
> current uses of ly_scm2bool are mapped to the most appropriate of either
> to_boolean behavior under the guise of "new ly_scm2bool" or to
> scm_is_true).  But not intermingled with this issue, and most certainly
> not half-intermingled with this issue.

You're right - patch updated accordingly.

thanks,
Janek