|
| From: | janek . lilypond |
| Subject: | Re: Don't report a programming error when trying to align grob with an empty extent (issue 7533046) |
| Date: | Tue, 26 Mar 2013 21:49:40 +0000 |
On 2013/03/24 16:39:03, Trevor Daniels wrote:
> Please choose between patchsets 4 and 5.
I prefer 5. The warning does no harm if it is never triggered, but is there in case some future change elsewhere assumes a non-empty stencil will be aligned even if its extent is empty. It is relevant to these alignment routines as they cannot calculate the offset required to achieve the specified alignment of such grobs, so should warn if a caller appears to be expecting them to do that.
Aaaand the winner is... patchset 5! Seriously though, Trevor's argument convinced me. pushed as 1656075e24330067ff1dfa4d8253e5f3e5783014, closed. https://codereview.appspot.com/7533046/
| [Prev in Thread] | Current Thread | [Next in Thread] |