lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Snaps horizontally-offset fingerings to vertical column. (issue 7988


From: ianhulin44
Subject: Re: Snaps horizontally-offset fingerings to vertical column. (issue 7988043)
Date: Sun, 24 Mar 2013 14:00:44 +0000

Suggestion for regression test doc-string.
It's a bit wordier but clearer and shows you're covering cases for other
wide accidentals on the note being fingered like half-flat etc.
Cheers, Ian


https://codereview.appspot.com/7988043/diff/2001/input/regression/fingering-column-snap-radius.ly
File input/regression/fingering-column-snap-radius.ly (right):

https://codereview.appspot.com/7988043/diff/2001/input/regression/fingering-column-snap-radius.ly#newcode6
input/regression/fingering-column-snap-radius.ly:6: The default being
@code{0.3} allows the snap to happen for a sharp but
"The default value of @code{0.3} allows the snap to happen when the
fingering is applied to a note with a sharp but"

https://codereview.appspot.com/7988043/diff/2001/input/regression/fingering-column-snap-radius.ly#newcode7
input/regression/fingering-column-snap-radius.ly:7: not a double flat.
not to happen for notes with wider accidentals like double flat.

https://codereview.appspot.com/7988043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]