|
| From: | tdanielsmusic |
| Subject: | Re: Don't report a programming error when trying to align grob with an empty extent (issue 7533046) |
| Date: | Sun, 24 Mar 2013 12:37:14 +0000 |
I was a little concerned that problems might result when a non-empty stencil was given an empty extent, but as this passes all tests it looks like this fear was unfounded. So LGTM apart from a nitpick. Trevor https://codereview.appspot.com/7533046/diff/15001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/7533046/diff/15001/lily/self-alignment-interface.cc#newcode153 lily/self-alignment-interface.cc:153: // empty extent isn't a problem - we simply don't align such grobs. I think this comment would be better associated with the if condition so it covers the entire conditional clause. https://codereview.appspot.com/7533046/
| [Prev in Thread] | Current Thread | [Next in Thread] |