Re: Snaps horizontally-offset fingerings to vertical column. (issue 7988043)

[k-ohara5a5a]

Code looks good, but we could get the same result with
  \override Accidental #'horizontal-skylines = #'()

Incorporating the detailed outline of the accidental into the skyline of
the chord costs time, then the iterative alignment of fingering costs
more time, and if that alignment does anything it has the same effect as
skipping the detailed outline in the first place.

Does anything else (ties, maybe?) benefit from using the stencil of
accidentals for horizontal-skylines ?



https://codereview.appspot.com/7988043/diff/2001/input/regression/fingering-column-snap-radius.ly
File input/regression/fingering-column-snap-radius.ly (right):

https://codereview.appspot.com/7988043/diff/2001/input/regression/fingering-column-snap-radius.ly#newcode6
input/regression/fingering-column-snap-radius.ly:6: The default being
@code{0.3} allows the snap to happen for a sharp but
On 2013/03/24 14:00:44, Ian Hulin (gmail) wrote:
> "The default value of @code{0.3} allows the snap to happen when the
fingering is
> applied to a note with a sharp but"

That comment does not correspond to the behavior of the patch (nor does
Mike's).  All accidentals are wider than 0.3 spaces.  The question is
the shape of the outline of the left edge of the accidental
  <cis-1 a-1 e-1>4
  <cis!-1 a-1 d,-1>4
  <ceses-1 a-1 d,-1>4
  <ceses!-1 f,-1 d-1>4

https://codereview.appspot.com/7988043/