Re: Snaps horizontally-offset fingerings to vertical column. (issue 7988043)

[k-ohara5a5a]

LGTM, after removing the erroneous part of the regtest description.

On 2013/03/25 08:43:15, janek wrote:
> Accidentals themselves use skylines to position themselves snugly:
> http://code.google.com/p/lilypond/issues/detail?id=2811


Right. We decided it worth the time to have detailed skylines for
  { % \override Accidental #'horizontal-skylines = #'()
    <es' a'!> }

> Also, in tight music there are other grobs that may go close to
accidentals and
> benefit from precise positioning.

I would have thought that Fingering was an example that would benefit,
but people seem to want them lined up in boxes.
> best,
> Janek




https://codereview.appspot.com/7988043/diff/2001/lily/fingering-column.cc
File lily/fingering-column.cc (right):

https://codereview.appspot.com/7988043/diff/2001/lily/fingering-column.cc#newcode161
lily/fingering-column.cc:161: while (dirty);
After the first pass, we have
     fos[i].offset == fos[i+1].offset
     || fabs(fos[i].offset - fos[i+1].offset) >= snap
so any further passes through the loop do nothing.

https://codereview.appspot.com/7988043/